Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v2.8] Releasing v2.7 forward-ported charts into v2.8 #3274

Merged
merged 10 commits into from
Dec 18, 2023
Merged

[release-v2.8] Releasing v2.7 forward-ported charts into v2.8 #3274

merged 10 commits into from
Dec 18, 2023

Conversation

lucasmlp
Copy link
Contributor

@lucasmlp lucasmlp commented Dec 18, 2023 •
edited
Loading

Pull-Requests:

Charts Checklist (built for v0.5.2 charts-build-scripts)

Checkpoint 0: Validate release.yaml

Validation steps:

  • Each chart version in release.yaml DOES NOT modify an already released chart. If so, stop and modify the versions so that it releases a net-new chart.
  • Each chart version in release.yaml IS exactly 1 more patch version than the last released chart version. If not, stop and modify the versions so that it releases a net-new chart.

Checkpoint 1: Compare contents of assets/ to charts/

Validation steps:

  • Running make unzip to regenerate the charts/ from scratch, then git diff to check differences between assets/ and charts/ yields NO differences or innocuous differences.

IMPORTANT: Do not undo these changes for future steps since we want to keep the charts/ that match the current contents of assets!

Checkpoint 2: Compare assets against index.yaml

Validation steps:

  • Each chart has ALL required annotations
    • kube-version annotation
    • rancher-version annotation
    • permits-os annotation (indicates Windows and/or Linux)

@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:- 
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

rohitsakala
rohitsakala requested changes Dec 18, 2023
View reviewed changes
Copy link
Member

@rohitsakala rohitsakala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perform the release checklist as well.

@lucasmlp lucasmlp added the regsync-ready PR ready to sync images with prime registry label Dec 18, 2023
@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:- 
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@lucasmlp lucasmlp merged commit cb953fa into release-v2.8 Dec 18, 2023
5 checks passed
@rohitsakala rohitsakala deleted the oob-v2.8 branch December 18, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitsakala rohitsakala rohitsakala approved these changes

Assignees
No one assigned
Labels
regsync-ready PR ready to sync images with prime registry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasmlp @rohitsakala @rancherbot